[coreboot-gerrit] Change in coreboot[master]: mb/up/squared: rewrite GPIO config using intelp2m

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39765 )

Change subject: mb/up/squared: rewrite GPIO config using intelp2m
......................................................................

Patch Set 15:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39765/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39765/3//COMMIT_MSG@17 
PS3, Line 17: [WIP] Please review and test coreboot image with this patch
> These *. […]

Please ignore my previous comment!

GPIORXDIS, GPIOTXDIS RX and RXEVCFG fields in the DW0 register do not affect the pad in native function, and the PAD_CFG_NF() macro sets these fields to '0'. For this reason, we cannot validate these changes by building images with "make BUILD_TIMELESS = 1". The images are always different.