HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41289 )
Change subject: mb/google/eve: Remove direct 'include <soc/gpio.h>' ......................................................................
mb/google/eve: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: I371ec6f22304813a4914f688d08b0c1ed4e1e714 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/eve/bootblock.c M src/mainboard/google/eve/chromeos.c M src/mainboard/google/eve/spd/spd.c 3 files changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/41289/1
diff --git a/src/mainboard/google/eve/bootblock.c b/src/mainboard/google/eve/bootblock.c index 84b10ef..0a125a8 100644 --- a/src/mainboard/google/eve/bootblock.c +++ b/src/mainboard/google/eve/bootblock.c @@ -3,7 +3,6 @@ #include <bootblock_common.h> #include <ec/google/chromeec/ec.h> #include <gpio.h> -#include <soc/gpio.h> #include "gpio.h"
static void early_config_gpio(void) diff --git a/src/mainboard/google/eve/chromeos.c b/src/mainboard/google/eve/chromeos.c index 11931c6..2d4b511 100644 --- a/src/mainboard/google/eve/chromeos.c +++ b/src/mainboard/google/eve/chromeos.c @@ -2,7 +2,6 @@
#include <boot/coreboot_tables.h> #include <gpio.h> -#include <soc/gpio.h> #include <vendorcode/google/chromeos/chromeos.h>
#include "gpio.h" diff --git a/src/mainboard/google/eve/spd/spd.c b/src/mainboard/google/eve/spd/spd.c index 330ea52..bf7a9bc 100644 --- a/src/mainboard/google/eve/spd/spd.c +++ b/src/mainboard/google/eve/spd/spd.c @@ -3,7 +3,6 @@ #include <cbfs.h> #include <console/console.h> #include <gpio.h> -#include <soc/gpio.h> #include <soc/romstage.h> #include <string.h>