16 Apr
2020
16 Apr
'20
9:03 a.m.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35853 )
Change subject: src/southbridge/amd/pi/hudson/Makefile.inc: fix AMDFW outside CBFS ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35853/1/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35853/1/src/southbridge/amd/pi/huds... PS1, Line 76: HUDSON_FWM_POSITION=$(call int-add, $(call int-subtract, 0xffffffff $(CONFIG_ROM_SIZE)) 0x20000 1)
is it intended to not add the conversion here, but below? i would have added this here
I used the same approach as stoneyridge
--
To view, visit https://review.coreboot.org/c/coreboot/+/35853
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4b03f971b88acbc3392b66e084babe738659ea6
Gerrit-Change-Number: 35853
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 16 Apr 2020 09:03:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment