EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38526 )
Change subject: ec/google/wilco: add ec command set cpu id
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38526/4/src/ec/google/wilco/command...
File src/ec/google/wilco/commands.c:
https://review.coreboot.org/c/coreboot/+/38526/4/src/ec/google/wilco/command...
PS4, Line 231: * MBOX[3] = CPUID_Low
: * MBOX[4] = CPUID_Mid
: * MBOX[5] = CPUID_High
Ack
Done
https://review.coreboot.org/c/coreboot/+/38526/4/src/ec/google/wilco/command...
PS4, Line 237: */
space before * looks like it would align the comment. but this could be just a gerrit ui issue.
Done
https://review.coreboot.org/c/coreboot/+/38526/4/src/ec/google/wilco/command...
PS4, Line 240: uint8_t cpu_id[7] = {0}, i;
can you add a newline after the declaration and before the code?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38526
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I135d2421d2106934be996a1780786f6bb0bf6b34
Gerrit-Change-Number: 38526
Gerrit-PatchSet: 5
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jan 2020 03:17:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment