Attention is currently required from: Nico Huber.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48262 )
Change subject: mb/emulation/qemu-q35: Add support for SMM_TSEG with parallel MP init
......................................................................
Patch Set 10:
(1 comment)
File src/cpu/qemu-x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/48262/comment/8d882ae4_4ceb0635
PS8, Line 42: depends on PARALLEL_MP
In the light of the other comment thread, shouldn't this depend on X86_32?
allowing for later sizes is fixed in CB:50770. It causes problems if the stub > save state in the current state of the code. This happens to be the case on X86_32 in this CL, but is not necesarrily the case in alter ones that reduce the stub size. As it's fixed later on I'll just leave it like this for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48262
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I612cebcd2ddef809434eb9bfae9d8681cda112ef
Gerrit-Change-Number: 48262
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 16 Mar 2021 12:20:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
