Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45641 )
Change subject: mb/google/zork: Modify USB 2.0 PHY parameters for Woomax
......................................................................
Patch Set 6: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/45641/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45641/4//COMMIT_MSG@7
PS4, Line 7: mb/google/zork: Modify USB2.0 PHY parameters for improve usb eye diagram
You should mention this is for woomax in the subject.
Done
https://review.coreboot.org/c/coreboot/+/45641/4//COMMIT_MSG@32
PS4, Line 32: BUG=None
BUG=b:169207729
Done
https://review.coreboot.org/c/coreboot/+/45641/4//COMMIT_MSG@33
PS4, Line 33: BRANCH=None
Need a BRANCH=zork to ensure it gets cherry-picked to the firmware branch when landing at chromium
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45641
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I764238485a1a81eb0d4740ac58c80a43f965f550
Gerrit-Change-Number: 45641
Gerrit-PatchSet: 6
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Fri, 25 Sep 2020 01:55:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Peers
epeers@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment