Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35189 )
Change subject: util/inteltool: add many missing registers for skl/kbl
......................................................................
Uploaded patch set 8.
(3 comments)
https://review.coreboot.org/c/coreboot/+/35189/7/util/inteltool/apic.c
File util/inteltool/apic.c:
https://review.coreboot.org/c/coreboot/+/35189/7/util/inteltool/apic.c@110
PS7, Line 110: lx
This won't work on x86_32.
Done
https://review.coreboot.org/c/coreboot/+/35189/7/util/inteltool/apic.c@110
PS7, Line 110: ld
`i` is not a long, it's size_t?
Done
https://review.coreboot.org/c/coreboot/+/35189/7/util/inteltool/apic.c@111
PS7, Line 111: (uint16_t)
Why the cast?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bba1252635b3421051dd53f7d5adbd3d73ed1b6
Gerrit-Change-Number: 35189
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Oct 2019 21:09:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment