Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32090 )
Change subject: smbios: Add and adapt fields for SMBIOS update to version 3.2 ......................................................................
Patch Set 12:
(2 comments)
Patch Set 11:
(4 comments)
Line 280: Did somebody check *all* callers that they report the *clock*
frequency? The direct caller, I found, that immediately uses this those values, is in mosys. It is reported there as clock frequency in MHZ. Now, why would any caller report it/them in anything other than clock frequency? They have always been specified in the SMBIOS specs as clock frequencies in MHZ.
Line 804: Beside increasing the version, this change seems to only add optional fields. Did anybody check if there are any mandatory changes before increasing the version?
I did not find any indication/specification that the added fields is/are optional.
https://review.coreboot.org/#/c/32090/11/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32090/11/src/arch/x86/smbios.c@280 PS11, Line 280: t->speed = 2 * dimm->ddr_frequency;
Did somebody check *all* callers that they report the *clock* […]
Done
https://review.coreboot.org/#/c/32090/11/src/arch/x86/smbios.c@804 PS11, Line 804: se->minor_version = 2;
*if there are any mandatory changes to make
Done