Patch Set 11:

(4 comments)

Line 280: Did somebody check *all* callers that they report the *clock*
frequency?
The direct caller, I found, that immediately uses this those values, is in mosys. It is reported there as clock frequency in MHZ.
Now, why would any caller report it/them in anything other than clock frequency? They have always been specified in the SMBIOS specs as clock frequencies in MHZ.

Line 804: Beside increasing the version, this change seems to only add
optional fields. Did anybody check if there are any mandatory
changes before increasing the version?
I did not find any indication/specification that the added fields is/are optional.

View Change

2 comments:

To view, visit change 32090. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1171c20ac85a2231d949d4ac1c3e3c544ba3e5ef
Gerrit-Change-Number: 32090
Gerrit-PatchSet: 12
Gerrit-Owner: Francois Toguo Fotso <francois.toguo.fotso@intel.com>
Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso@intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Francois Toguo Fotso <francois.toguo.fotso@intel.corp-partner.google.com>
Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Comment-Date: Sun, 14 Apr 2019 02:53:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment