Patch Set 11:


Line 280: Did somebody check *all* callers that they report the *clock*
The direct caller, I found, that immediately uses this those values, is in mosys. It is reported there as clock frequency in MHZ.
Now, why would any caller report it/them in anything other than clock frequency? They have always been specified in the SMBIOS specs as clock frequencies in MHZ.

Line 804: Beside increasing the version, this change seems to only add
optional fields. Did anybody check if there are any mandatory
changes before increasing the version?
I did not find any indication/specification that the added fields is/are optional.

View Change


To view, visit change 32090. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1171c20ac85a2231d949d4ac1c3e3c544ba3e5ef
Gerrit-Change-Number: 32090
Gerrit-PatchSet: 12
Gerrit-Owner: Francois Toguo Fotso <>
Gerrit-Reviewer: Francois Toguo Fotso <>
Gerrit-Reviewer: Lijian Zhao <>
Gerrit-Reviewer: Nico Huber <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: Patrick Rudolph <>
Gerrit-Reviewer: Paul Menzel <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Francois Toguo Fotso <>
Gerrit-CC: HAOUAS Elyes <>
Gerrit-CC: Patrick Rudolph <>
Gerrit-Comment-Date: Sun, 14 Apr 2019 02:53:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <>
Gerrit-MessageType: comment