4 Feb
2019
4 Feb
'19
5:53 p.m.
mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31225 )
Change subject: src/mainboard/lenovo/g505s/Kconfig: disable DRIVERS_INTEL_WIFI by default ......................................................................
Patch Set 2:
Patch Set 2: Code-Review-1
I agree with git blame on how conditionals are currently set.
How could I improve this change? Please could you provide any ideas?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31225
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73c3c2587690dca653dd1b2a8d6ee9ff8b769ad4
Gerrit-Change-Number: 31225
Gerrit-PatchSet: 2
Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com
Gerrit-Comment-Date: Mon, 04 Feb 2019 17:53:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment