Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35795 )
Change subject: sb/intel/i82801gx: Move CIR init to a common place ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35795/3/src/mainboard/asus/p5gc-mx/... File src/mainboard/asus/p5gc-mx/romstage.c:
https://review.coreboot.org/c/coreboot/+/35795/3/src/mainboard/asus/p5gc-mx/... PS3, Line 151: 0x10030509;
this value is not the same […]
Ack
https://review.coreboot.org/c/coreboot/+/35795/3/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/early_cir.c:
https://review.coreboot.org/c/coreboot/+/35795/3/src/southbridge/intel/i8280... PS3, Line 28: 0x10030549
looks like this is RO […]
Ack