Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48656 )
Change subject: mb/google/dedede: Update galtic device tree ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/48656/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/galtic/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48656/4/src/mainboard/google/dedede... PS4, Line 11: Audio Trackpad based on your config below.
https://review.coreboot.org/c/coreboot/+/48656/4/src/mainboard/google/dedede... PS4, Line 13: Trackpad Audio based on your config below.
https://review.coreboot.org/c/coreboot/+/48656/4/src/mainboard/google/dedede... PS4, Line 39: # USB Port Configuration register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # Camera
https://review.coreboot.org/c/coreboot/+/48656/4/src/mainboard/google/dedede... PS4, Line 56: device usb 2.6 on end Why is it on? If you are not planning to use it, leave it off.
https://review.coreboot.org/c/coreboot/+/48656/4/src/mainboard/google/dedede... PS4, Line 79: ACPI_IRQ_WAKE_EDGE_LOW HID devices should have level triggered interrupt.
https://review.coreboot.org/c/coreboot/+/48656/4/src/mainboard/google/dedede... PS4, Line 90: ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ) HID devices should have Level Triggered interrupt.