Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43612 )
Change subject: ec/system76_ec: add support for System76 EC ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43612/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43612/14//COMMIT_MSG@10 PS14, Line 10: EC_SYSTEM76_EC why not EC_SYSTEM76?
https://review.coreboot.org/c/coreboot/+/43612/14/src/console/console.c File src/console/console.c:
https://review.coreboot.org/c/coreboot/+/43612/14/src/console/console.c@25 PS14, Line 25: __system76_ec_init(); I'm not sure if that's the right place to init the ec. I expect the ec driver to get more functionality over time. Why not do it like the other ec and use chip_operations/enable_dev?