Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37871 )
Change subject: soc/intel/common/block: Enable PMC IPC driver in Coreboot ......................................................................
Patch Set 5:
(7 comments)
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... PS1, Line 45: enum errors { : SUCCESS = 0, : E_TIMEOUT = -1, : E_HW_ERROR = -2, : E_ARGUMENT = -3, : };
Please extend the CB_SUCCESS and friends structure.
Done
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... PS1, Line 624:
Please print out the stopwatch time.
Done
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... PS1, Line 627: : int
Please use CB_SUCCESS and friends.
Done
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... PS1, Line 640: /
Please add spaces around the operator.
Done
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... PS1, Line 643: BIOS_ERR
this should be BIOS_SPEW or BIOS_DEBUG.
Done
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... PS1, Line 651: BIOS_DEBUG
BIOS_ERR
Done
https://review.coreboot.org/c/coreboot/+/37871/1/src/soc/intel/common/block/... PS1, Line 658: *
Please add spaces.
Done