Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42807 )
Change subject: soc/amd/common: Separate single GPIO programming ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42807/1/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42807/1/src/soc/amd/common/block/gp... PS1, Line 230: continue;
return;
Done
https://review.coreboot.org/c/coreboot/+/42807/2/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42807/2/src/soc/amd/common/block/gp... PS2, Line 251: &sci_trigger_cfg); *sigh* drop &