[coreboot-gerrit] Change in coreboot[master]: trogdor: QCSDI loading depends on VB2_GBB_FLAG_RUNNING_FAFT setting flag

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36518 )

Change subject: trogdor: QCSDI loading depends on VB2_GBB_FLAG_RUNNING_FAFT setting flag
......................................................................

Patch Set 36:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36518/28/src/soc/qualcomm/common/qc... 
File src/soc/qualcomm/common/qclib.c:

https://review.coreboot.org/c/coreboot/+/36518/28/src/soc/qualcomm/common/qc... 
PS28, Line 130: 	struct vb2_context *ctx = vboot_get_context();
> Julius, we have tried your suggestion as is and it introduced issues that were picked up by BVT test […]

I mean... I'm not suggesting you change anything functionally, I'm just asking you to rewrite it so that it will build correctly when CONFIG_VBOOT is disabled. If you saw a functional change with that you must have made some mistake. If you upload what you tried, maybe I can help you find it.