Attention is currently required from: Martin Roth, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78222?usp=email )
Change subject: soc/amd/genoa: Add GPIO support
......................................................................
Patch Set 7:
(2 comments)
File src/soc/amd/genoa/gpio.c:
https://review.coreboot.org/c/coreboot/+/78222/comment/5f4d1e2b_e8ae000e :
PS7, Line 16: { GPIO_7, GEVENT_11 },
GPIO7 can't cause a gevent. gevent 11 is generated by another gpio in the list
https://review.coreboot.org/c/coreboot/+/78222/comment/39974b66_7775a81e :
PS7, Line 23: { GPIO_26, GEVENT_15 },
{ GPIO_28, GEVENT_18 }, is missing. not 100% sure if gpio 28 really exists though
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78222?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2e827e9ffbb2ec1be0f1247b77660a9fdeb04f7b
Gerrit-Change-Number: 78222
Gerrit-PatchSet: 7
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 09 Oct 2023 22:08:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment