Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32263 )
Change subject: google/kukui: Include panel identifier (LCM ID) into SKU ID ......................................................................
Patch Set 5: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/32263/5/src/mainboard/google/kukui/boardid.c File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/#/c/32263/5/src/mainboard/google/kukui/boardid.c... PS5, Line 26: KUKUI_LCM_ID_CHANNEL = 2, nit: wouldn't calling this PANEL or DISPLAY (rather than LCM) everywhere be a bit more obvious? (what exactly does LCM mean, anyway? liquid crystal mmm...odule? manifold?)
https://review.coreboot.org/#/c/32263/5/src/mainboard/google/kukui/boardid.c... PS5, Line 33: static const int voltages_default[] = { nit: I think this would look cleaner if the voltages arrays were global and you passed a pointer to the right one through to get_index().