[coreboot-gerrit] Change in coreboot[master]: mb/amd/mandolin: Add Picasso CRB

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33772 )

Change subject: mb/amd/mandolin: Add Picasso CRB
......................................................................

Patch Set 46:

(4 comments)

https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... 
File src/mainboard/amd/mandolin/irq_tables.c:

https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... 
PS42, Line 28: write_pirq_routing_table
> wow, this method is complicated...

Done. removed the whole file

https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... 
PS42, Line 56: 0x1002
> good idea

Done

https://review.coreboot.org/c/coreboot/+/33772/42/src/mainboard/amd/mandolin... 
PS42, Line 68: 0xdef8
> What is this bitmap format?

Done

https://review.coreboot.org/c/coreboot/+/33772/43/src/mainboard/amd/mandolin... 
File src/mainboard/amd/mandolin/mptable.c:

PS43:
> not sure. […]

Done. removed mptable