Seunghwan Kim has uploaded this change for review. ( https://review.coreboot.org/29631
Change subject: mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only ......................................................................
mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only
GPP_D0 is NC in 1st SKU board design, so we should control GPP_D0 for only 2nd SKU.
BUG=none BRANCH=poppy TEST=emerge-nautilus coreboot
Change-Id: Ifd85693c9155ed960f0c794d4b83fe8863b77134 Signed-off-by: Seunghwan Kim sh_.kim@samsung.com --- M src/mainboard/google/poppy/variants/nautilus/Makefile.inc M src/mainboard/google/poppy/variants/nautilus/smihandler.c 2 files changed, 12 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/29631/1
diff --git a/src/mainboard/google/poppy/variants/nautilus/Makefile.inc b/src/mainboard/google/poppy/variants/nautilus/Makefile.inc index 130c940..c715206 100644 --- a/src/mainboard/google/poppy/variants/nautilus/Makefile.inc +++ b/src/mainboard/google/poppy/variants/nautilus/Makefile.inc @@ -15,3 +15,4 @@ ramstage-y += sku.c
smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c +smm-$(CONFIG_HAVE_SMI_HANDLER) += sku.c diff --git a/src/mainboard/google/poppy/variants/nautilus/smihandler.c b/src/mainboard/google/poppy/variants/nautilus/smihandler.c index e355b01..d581168 100644 --- a/src/mainboard/google/poppy/variants/nautilus/smihandler.c +++ b/src/mainboard/google/poppy/variants/nautilus/smihandler.c @@ -16,13 +16,22 @@ #include <arch/acpi.h> #include <baseboard/variants.h> #include <gpio.h> +#include <variant/sku.h>
#define LTE3_PWROFF_L GPP_D0
void variant_smi_sleep(u8 slp_typ) { + uint32_t sku_id = variant_board_sku(); + if (slp_typ == ACPI_S5) { - /* Turn off LTE module */ - gpio_set(LTE3_PWROFF_L, 0); + switch (sku_id) { + case SKU_1_NAUTILUS_LTE: + /* Turn off LTE module */ + gpio_set(LTE3_PWROFF_L, 0); + break; + default: + break; + } } }