Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47259 )
Change subject: soc/intel/tigerlake: Update Kconfig for NEM Enhanced Mode
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47259/13/src/soc/intel/tigerlake/Kc...
File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47259/13/src/soc/intel/tigerlake/Kc...
PS13, Line 26: USE_CAR_NEM_ENHANCED_V1
You will need the mainboard Kconfig changes in the same file to ensure that the selection is correct for all boards.
Also, I think it would be good to start with USE_CAR_NEM_ENHANCED_V2 in this CL and switch to USE_CAR_NEM_ENHANCED_V1 in follow-up CL so that this change is only about flipping the configs while keeping the functionality same. And the follow-up CL will actually switch from V2 to V1.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47259
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6e041261cb8ca9c6e602935da4962aac0d9ece5
Gerrit-Change-Number: 47259
Gerrit-PatchSet: 13
Gerrit-Owner: Shreesh Chhabbi
shreesh.chhabbi@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shreesh Chhabbi
shreesh.chhabbi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Comment-Date: Wed, 11 Nov 2020 00:50:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment