Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47051 )
Change subject: mb/purism/librem_cnl: Adjust in preparation for new variants ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... PS1, Line 4: select SOC_INTEL_WHISKEYLAKE
This is just describing the example, it is definitely not a rule. […]
It doesn't look like a rule, yeah but it still makes it pretty clear how that choice/names mechanism *should* be used. What I fear is, that if we start adding stuff to Kconfig.names, is that people will follow and Kconfig/Kconfig.names get mixed up very soon, making it pretty confusing. Surely that won't happen with a single select, but I'm sure more will follow :D