29 Apr
2021
29 Apr
'21
5:56 p.m.
Attention is currently required from: Martin Roth, Zheng Bao. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52657 )
Change subject: amdfwtool: Remove the misleading option characters ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Why? How are these misleading? It's very common for programs to have both short and long options. […]
the reason is that we are almost out of letters. and in future, more FW need to be added and more letters are needed. Even now many letters were picked at random.
Maybe we should keep some short option like -h -d?
--
To view, visit https://review.coreboot.org/c/coreboot/+/52657
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b0d53d5e5eb494741b7fac32029cf16cabe66d8
Gerrit-Change-Number: 52657
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Eric Peers epeers@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Thu, 29 Apr 2021 08:56:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth martinroth@google.com
Gerrit-MessageType: comment