Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46402 )
Change subject: soc/mediatek/mt8192: devapc: add basic devapc drivers ......................................................................
Patch Set 53:
(6 comments)
https://review.coreboot.org/c/coreboot/+/46402/53//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46402/53//COMMIT_MSG@11 PS53, Line 11: setup "set up"
https://review.coreboot.org/c/coreboot/+/46402/53//COMMIT_MSG@13 PS53, Line 13: DAPC Either move to the previous line or start with a new paragraph.
https://review.coreboot.org/c/coreboot/+/46402/53//COMMIT_MSG@14 PS53, Line 14: . A space after "."
https://review.coreboot.org/c/coreboot/+/46402/53/src/soc/mediatek/mt8192/de... File src/soc/mediatek/mt8192/devapc.c:
https://review.coreboot.org/c/coreboot/+/46402/53/src/soc/mediatek/mt8192/de... PS53, Line 6: uint32_t Can we return void* here?
https://review.coreboot.org/c/coreboot/+/46402/53/src/soc/mediatek/mt8192/de... PS53, Line 46: devapc_base[i] What is this condition for? Can we use
i < ARRAY_SIZE(devapc_base)
https://review.coreboot.org/c/coreboot/+/46402/53/src/soc/mediatek/mt8192/in... File src/soc/mediatek/mt8192/include/soc/devapc.h:
https://review.coreboot.org/c/coreboot/+/46402/53/src/soc/mediatek/mt8192/in... PS53, Line 19: UNSIGNED_MAX Where is this used?