build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45939 )
Change subject: fw_config: Convert fw_config to a 64-bit field
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45939/1/util/sconfig/main.c
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/45939/1/util/sconfig/main.c@464
PS1, Line 464: printf("ERROR: fw_config option %s:%s value %u larger than field max %" PRIx64 "\n",
line over 96 characters
https://review.coreboot.org/c/coreboot/+/45939/1/util/sconfig/main.c@551
PS1, Line 551: fprintf(fil, "#define FW_CONFIG_FIELD_%s_OPTION_%s_VALUE 0x%" PRIx64 "\n",
line over 96 characters
https://review.coreboot.org/c/coreboot/+/45939/1/util/sconfig/main.c@552
PS1, Line 552: field->name, option->name, (uint64_t)(option->value << (uint64_t)field->start_bit));
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f2065d347eafa0ef7b346caeabdc3b626402092
Gerrit-Change-Number: 45939
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 01 Oct 2020 22:23:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment