[coreboot-gerrit] [M] Change in coreboot[main]: lib/romstage_handoff.c: Initialize using a cbmem hook

[Arthur Heymans (Code Review)]

Attention is currently required from: Andrey Petrov, Angel Pons, Damien Zammit, Felix Held, Huang Jin, Julius Werner, Lee Leahy, Matt DeVillier, Ronak Kanabar.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52933?usp=email )

Change subject: lib/romstage_handoff.c: Initialize using a cbmem hook
......................................................................

Patch Set 6: Code-Review-1

(1 comment)

File src/lib/romstage_handoff.c:

https://review.coreboot.org/c/coreboot/+/52933/comment/e6e79423_4dfd8636 :
PS3, Line 56: ROMSTAGE_CBMEM_INIT_HOOK(romstage_handoff_init);
> > Since this file is compiled unconditionally, adding an INIT_HOOK() expands this to a lot of platforms which never used it. Please add a Kconfig to limit compilation of the file to the right set of boards if you want to do this (I'm not quite sure what exactly this is or what the right set of boards for it would be, but I know the Arm boards I work on don't use this, for example).
>
> Done. HAVE_ACPI_RESUME is the proper flag.

Hmm there are other flags in there.