Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33433 )
Change subject: mainboard/facebook/fbg1701: Configure TC358860 eDP to MIPI controller
......................................................................
Patch Set 15:
(1 comment)
If there are no big concerns, I'll merge this patch in the current state tomorrow; the remaining nitpicks can be addressed in a follow-up patch
https://review.coreboot.org/#/c/33433/15/src/mainboard/facebook/fbg1701/rams...
File src/mainboard/facebook/fbg1701/ramstage.c:
https://review.coreboot.org/#/c/33433/15/src/mainboard/facebook/fbg1701/rams...
PS15, Line 363: 1920
Looks like this board is part of an integrated device. […]
maybe change this comment to the full resolution specification (1920x1200) in a separate patch on top of this one
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33433
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I262cb4376b86db94e3bb9522c556b5cc3ff38335
Gerrit-Change-Number: 33433
Gerrit-PatchSet: 15
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 21 Jun 2019 16:01:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment
