Attention is currently required from: Gaggery Tsai, Marx Wang.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48510 )
Change subject: soc/intel/apollolake: Provide the option to enable DDR 2x refresh rate
......................................................................
Patch Set 14: Code-Review+1
(1 comment)
File src/soc/intel/apollolake/Kconfig:
https://review.coreboot.org/c/coreboot/+/48510/comment/9117224a_6e7ffb6c
PS14, Line 431: ENABLE_DDR_2X_REFRESH
I guess we don't need this since the rh_mitigation flag is passed from mainboard memory setup alread […]
Yeah, I agree. At first I thought that the patch enabled 2x refresh for everything, but it's no longer the case. Please also update the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0235fc7906626f28f14367c283433e5b066cc89a
Gerrit-Change-Number: 48510
Gerrit-PatchSet: 14
Gerrit-Owner: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Attention: Marx Wang
marx.wang@intel.com
Gerrit-Comment-Date: Sun, 14 Mar 2021 08:28:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-MessageType: comment