build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33810 )
Change subject: [test] Wduplicated-branches and Wduplicated-cond warning options ......................................................................
Patch Set 10:
(12 comments)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr2.c File src/device/dram/ddr2.c:
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr2.c@528 PS10, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr2.c@528 PS10, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr2.c@528 PS10, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr2.c@528 PS10, Line 528: printram(" Capacity : %u",((dimm->size_mb < 1024)? dimm->size_mb: dimm->size_mb >> 10)); spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr2.c@529 PS10, Line 529: printram((dimm->size_mb < 1024)? " MB\n": " GB\n"); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr2.c@529 PS10, Line 529: printram((dimm->size_mb < 1024)? " MB\n": " GB\n"); spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr3.c File src/device/dram/ddr3.c:
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr3.c@184 PS10, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); line over 96 characters
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr3.c@184 PS10, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr3.c@184 PS10, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr3.c@184 PS10, Line 184: printram(" Capacity : %u ",((capacity_shift < 0x02)? 256 << capacity_shift: 1 << (capacity_shift - 2))); spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr3.c@185 PS10, Line 185: printram((capacity_shift < 0x02)? " Mb\n": " Gb\n"); spaces required around that '?' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/33810/10/src/device/dram/ddr3.c@185 PS10, Line 185: printram((capacity_shift < 0x02)? " Mb\n": " Gb\n"); spaces required around that ':' (ctx:VxW)