Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39167 )
Change subject: soc/tigerlake: Correct FSP log interface ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39167/5/src/soc/intel/tigerlake/rom... File src/soc/intel/tigerlake/romstage/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/39167/5/src/soc/intel/tigerlake/rom... PS5, Line 64: DEBUG_INTERFACE_TRACEHUB Why is DEBUG_INTERFACE_TRACEHUB being set unconditionally? Shouldn't this be dependent on the NPK device being enabled in devicetree? Also, don't you need to set other UPDs for Tracehub enabling?