[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/cpu: Refactor init_cpus function

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44076 )

Change subject: soc/intel/common/block/cpu: Refactor init_cpus function
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44076/5/src/soc/intel/common/block/... 
File src/soc/intel/common/block/cpu/mp_init.c:

https://review.coreboot.org/c/coreboot/+/44076/5/src/soc/intel/common/block/... 
PS5, Line 142: intel_microcode_load_unlocked
> Then, we might as well skip it when using FSP MP init, right?

yes, we are calling that function bt as ucode is already loaded on all cores hence this additional step got skipped. Do you recommend to move this ucode loading into line 152 below inside coreboot_init_cpus() ?