Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29480 )
Change subject: mb/kontron/bsl6: Add new Skylake COMe module
......................................................................
Patch Set 32:
(2 comments)
https://review.coreboot.org/c/coreboot/+/29480/24//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/29480/24//COMMIT_MSG@11
PS24, Line 11:
*poke*
Done
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6...
File src/mainboard/kontron/bsl6/gpio.h:
https://review.coreboot.org/c/coreboot/+/29480/29/src/mainboard/kontron/bsl6...
PS29, Line 226: PAD_CFG_NF(GPP_I10, NONE, PLTRST, NF1),
I also think we should remove the comments, since this way feels wrong, but no idea how to do it bet […]
I've removed the comments, doesn't seem worth waiting for somebody with the
time to maintain them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29480
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2b6a3f1e9dd095463f1f1521068b9f66a9189c5
Gerrit-Change-Number: 29480
Gerrit-PatchSet: 32
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Aug 2020 13:55:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment