Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46141 )
Change subject: soc/intel/common: Add PCI driver for USB4 ports ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46141/4/src/soc/intel/common/block/... File src/soc/intel/common/block/usb4/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46141/4/src/soc/intel/common/block/... PS4, Line 1: usb4
This file is added here and in the next CL gets dropped? I am confused.
That one needs a rebase.
https://review.coreboot.org/c/coreboot/+/46141/4/src/soc/intel/common/block/... File src/soc/intel/common/block/usb4/usb4.c:
https://review.coreboot.org/c/coreboot/+/46141/4/src/soc/intel/common/block/... PS4, Line 17: scan_generic_bus
Do we need a separate driver basically because we want the ability to scan for downstream non-PCI de […]
Yes, that's exactly it. I'll update the commit message to make that clear.