HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44209 )
Change subject: soc/samsung: Add missing <commonlib/helpers.h> ......................................................................
Patch Set 1:
Patch Set 1:
Do you mean relocating definitions from commonlib/bsd/helpers.h or including commonlib/helpers.h through types.h ?
No I mean just putting #include <types.h> here (which chain-includes that stuff). Those definitions are in commonlib for a reason, but those reasons are complicated (licensing and code sharing stuff) and I don't think every random source file in coreboot should be bothered by them (especially since they may change in the future). I think it would be much easier for all of us (and help keep attention focused on the important stuff) to just use types.h as a catchall header for all the random type and helper stuff.
Julius, I got a problem with <types.h> here : https://qa.coreboot.org/job/coreboot-gerrit/136626/ would you please have a look at it when you have time? Thx