Hello build bot (Jenkins), Nico Huber, Matt DeVillier, Paul Menzel, Angel Pons, Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43410
to look at the new patch set (#5).
Change subject: mb/51nb/x210/gpio: Convert configuration to macros ......................................................................
mb/51nb/x210/gpio: Convert configuration to macros
Use the intelp2m utility [1,2] to convert the current pad configuration format to the format with the the PAD_CFG() macros (*).
$ ./intelp2m -n -t 1 -p snr -file src/mainboard/51nb/x210/gpio.h
Unlike the raw DW0 and DW1 registers values from the inteltool dump, is more understandable and makes the code much cleaner.
[*] To do this, ignore some bit fields. See Patchset 1 | 86b3146261: https://review.coreboot.org/c/coreboot/+/43410/1
[1] https://github.com/maxpoliak/pch-pads-parser [2] https://review.coreboot.org/c/coreboot/+/35643
Change-Id: I18c0c321561eee04ff927681b0a231f6d79c63e2 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/51nb/x210/gpio.h 1 file changed, 164 insertions(+), 164 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/43410/5