Attention is currently required from: Marshall Dawson, Arthur Heymans, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44295 )
Change subject: cpu/amd/agesa: Use common MRC_CACHE code to save S3 data
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/44295/comment/efe9d11a_caa78161
PS8, Line 11: is not rewritten all the time. This prolongs the hardware's life.
AMDFW_OUTSIDE_CBFS option may be obsolete or unused, expect for ChromeOS and stoneyridge -combinat […]
CB:35853
https://ticket.coreboot.org/issues/224
What I meant was that instead of analyzing if AMDFW_OUTSIDE_CBFS together with FMAP causes problems, we might be able to drop it entirely. But some Kconfigs that are unused in upstream repo are used with ChromeOS configs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44295
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f4f36dcead52a6c550fb5e606772e0a99029872
Gerrit-Change-Number: 44295
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@tutanota.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 23 May 2022 06:46:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment