Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46091 )
Change subject: mb/intel/adlrvp: Add ADL-P romstage mainboard code ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46091/1/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/board_id.c:
https://review.coreboot.org/c/coreboot/+/46091/1/src/mainboard/intel/adlrvp/... PS1, Line 30: uint8_t This should be `size_t` b/c that's what `sizeof` returns. Will also need #include <types.h>
https://review.coreboot.org/c/coreboot/+/46091/1/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/46091/1/src/mainboard/intel/adlrvp/... PS1, Line 16: (get_board_id() & 0x3F); Should `get_board_id()` just always mask its return value with 0x3F in the function?
https://review.coreboot.org/c/coreboot/+/46091/1/src/mainboard/intel/adlrvp/... File src/mainboard/intel/adlrvp/variants/adlrvp_p/memory.c:
https://review.coreboot.org/c/coreboot/+/46091/1/src/mainboard/intel/adlrvp/... PS1, Line 15: .dq_map = { : { 0, 2, 3, 1, 6, 7, 5, 4, /* Byte 0 */ : 10, 8, 11, 9, 14, 12, 13, 15 }, /* Byte 1 */ : { 12, 8, 14, 10, 11, 13, 15, 9, /* Byte 2 */ : 5, 0, 7, 3, 6, 2, 1, 4 }, /* Byte 3 */ : { 3, 0, 2, 1, 6, 5, 4, 7, /* Byte 4 */ : 12, 13, 14, 15, 10, 9, 8, 11 }, /* Byte 5 */ : { 2, 6, 7, 1, 3, 4, 0, 5, /* Byte 6 */ : 9, 13, 8, 15, 14, 11, 12, 10 }, /* Byte 7 */ : { 3, 0, 1, 2, 7, 4, 6, 5, /* Byte 0 */ : 10, 8, 11, 9, 14, 13, 12, 15 }, /* Byte 1 */ : { 10, 12, 14, 8, 9, 13, 15, 11, /* Byte 2 */ : 3, 7, 6, 2, 0, 4, 5, 1 }, /* Byte 3 */ : { 12, 15, 14, 13, 9, 10, 11, 8, /* Byte 4 */ : 7, 4, 6, 5, 0, 1, 3, 2 }, /* Byte 5 */ : { 0, 2, 4, 3, 1, 6, 7, 5, /* Byte 6 */ : 13, 9, 10, 11, 8, 12, 14, 15 }, /* Byte 7 */ nit: line up the comments
https://review.coreboot.org/c/coreboot/+/46091/1/src/mainboard/intel/adlrvp/... PS1, Line 41: Baseboard uses 100, 100 and 100 rcomp resistors nit: maybe Baseboard uses only 100ohm Rcomp resistors