Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43394 )
Change subject: Makefile.inc: Add Boot Guard IBB logic for CBFS files
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43394/1/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43394/1/Makefile.inc@719
PS1, Line 719: BTGIBB
can't this be merged with TXTIBB. […]
TXTIBB sets a little bit more than Boot Guard. Although according to the spec IBB should initialize memory, IMO it is not necessary if we start measured/verified boot in botoblock. That was my motivation for separate IBB. Also there is a limit of FIT entries for Skylake equal 10. This amount of IBB elements would not fit into the table.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43394
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73e23ddbd8c7f6eef2de3cd3baeb656c86917261
Gerrit-Change-Number: 43394
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 13 Jul 2020 09:15:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment