Attention is currently required from: Martin Roth, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78220?usp=email )
Change subject: soc/amd/genoa: Add GPIO definitions
......................................................................
Patch Set 7:
(2 comments)
File src/soc/amd/genoa/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/78220/comment/e463496e_e1d51982 :
PS7, Line 41: #define GPIO_28 28
i'd drop this one, since it doesn't seem to exist on the package
https://review.coreboot.org/c/coreboot/+/78220/comment/02e815d7_2eac8f65 :
PS7, Line 148: #define GPIO_28_IOMUX_GPIOxx 1
i don't see this pin on the package, so we should probably not include it here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78220?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0c4e425699c9a158ca95a1baf94f7756f0b12b44
Gerrit-Change-Number: 78220
Gerrit-PatchSet: 7
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Tue, 10 Oct 2023 16:05:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment