Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Karthik Ramasubramanian. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56683 )
Change subject: soc/amd/common/block/spi: Enable host burst to 4 DWORD when using DMA ......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/spi/fch_spi.c:
https://review.coreboot.org/c/coreboot/+/56683/comment/f0ef8105_6a776791 PS1, Line 64: if (!CONFIG(SOC_AMD_COMMON_BLOCK_LPC_SPI_DMA)) Is this only being used in the case of using the SPI DMA? IIRC we needed to do the fch_spi_disable_4dw_burst call for stoneyridge due to some silicon bug. If there are some other cases where keeping the 4DW bursts enabled when not using the SPI DMA would be useful, it's probably better to have an additional kconfig option like SOC_AMD_COMMON_BLOCK_LPC_SPI_4DW_BURST which gets selected by SOC_AMD_COMMON_BLOCK_LPC_SPI_DMA.
I don't think that printing a debug message would be useful here; only thing it would do is adding some boot time