12 Sep
2019
12 Sep
'19
6:05 a.m.
DAWEI CHIEN has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34545 )
Change subject: mediatek/mt8183: Init SPM driver ......................................................................
Patch Set 35:
(1 comment)
Patch Set 35:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34545/17/src/soc/mediatek/mt8183/sp... File src/soc/mediatek/mt8183/spm.c:
https://review.coreboot.org/c/coreboot/+/34545/17/src/soc/mediatek/mt8183/sp... PS17, Line 309: while
In my opinion, even usually spm don't take more time to switch status, we still need give SPM time u […]
Hi Hung-Te, I would change state to done if you don't have new comment, thank you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/34545
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3393a772f025b0912a5a25a63a87512454fbc86e
Gerrit-Change-Number: 34545
Gerrit-PatchSet: 35
Gerrit-Owner: DAWEI CHIEN dawei.chien@mediatek.com
Gerrit-Reviewer: DAWEI CHIEN dawei.chien@mediatek.com
Gerrit-Reviewer: Huayang Duan huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: SJ Huang sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 12 Sep 2019 04:05:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: DAWEI CHIEN dawei.chien@mediatek.com
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Gerrit-MessageType: comment