Attention is currently required from: Bora Guvendik, Cliff Huang, Jamie Ryu, Jérémy Compostella.
Wonkyu Kim has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/87247?usp=email )
Change subject: ec/intel: read board ID one time from EC per stage ......................................................................
Patch Set 6:
(4 comments)
File src/ec/intel/board_id.c:
https://review.coreboot.org/c/coreboot/+/87247/comment/a210dcd1_8479420f?usp... : PS5, Line 21: int get_rvp_board_id(void)
I am realizing that it has little flow. […]
Done
https://review.coreboot.org/c/coreboot/+/87247/comment/87293503_874b0dfd?usp... : PS5, Line 21: get_rvp_board_id
Still a valid point.
Done
https://review.coreboot.org/c/coreboot/+/87247/comment/95e6775a_ab3daa1f?usp... : PS5, Line 25: Reading board id after first time reading
nit: Reading board **ID** after **the** first time reading
Done
https://review.coreboot.org/c/coreboot/+/87247/comment/18047e7d_d2b7a764?usp... : PS5, Line 29: Reading board id first time
Reading board **ID for the** first time
Done