[coreboot-gerrit] Change in coreboot[master]: rockchip/rk3399: Add MIPI driver

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19477 )

Change subject: rockchip/rk3399: Add MIPI driver
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/19477/11/src/soc/rockchip/rk3399/mipi.c
File src/soc/rockchip/rk3399/mipi.c:

PS11, Line 98: ret
Coverity identified that this value is returned uninitialized. Would you mind submitting a follow-up patch to fix that?

You're generally not very clean with return value handling in here. You should make sure your functions are either void or the return value is actually checked by the caller.