Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37094 )
Change subject: Revert "3rdparts/fsp: Update fsp submodule"
......................................................................
Patch Set 2:
Patch Set 2:
Okay lets ease down here. I just double checked. What we could to is change this here - and instead of reverting it, just use commit 573bd5d6861376c8b4947d177dfe70592ff80fc2 (which is the renaming one) and use this as the submodule commit for now.
To be honest - I dont think it's my responsibility to debug the FSP now (how could I) - I am just notifying about the error - reverting this and we are go to go again.
Commit 573bd5d6861376c8b4947d177dfe70592ff80fc2 seems to work.
Thanks for checking. I am surprised that 5391d1f is already bad, but okay. Can we use 5391d1f^ as new submodule commit?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37094
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58ee2d7ee2c12558498f02219ee45d61d942077e
Gerrit-Change-Number: 37094
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 11 Dec 2019 19:43:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment