Attention is currently required from: Frank Chu.
Mac Chiang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60413 )
Change subject: mb/google/volteer: Add fw confing MAX98373_ALC5682IVS_I2S_UP4 for codec 2nd source
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/volteer/fw_config.c:
https://review.coreboot.org/c/coreboot/+/60413/comment/7d326e29_2626b396
PS3, Line 105: printk(BIOS_INFO, "Configure GPIOs for I2S audio on UP4.\n");
Hi Frank,
As per our discussion in CL:60415, we can remove MAX98373_ALC5682IVS_I2S_UP4 fw_config.
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/60413/comment/5b106409_26df5f2d
PS3, Line 23: option MAX98373_ALC5682IVS_I2S_UP4 7
remove MAX98373_ALC5682IVS_I2S_UP4 fw_config.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60413
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d857101a8143ae4b074666d8ed478cc188a0435
Gerrit-Change-Number: 60413
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Anson Tseng
ansontseng@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mac Chiang
mac.chiang@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Isaac Lee
isaaclee@google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Tue, 25 Jan 2022 10:19:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment