Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45045 )
Change subject: soc/amd/picasso: Move DRAM end to after transfer buffer ......................................................................
Patch Set 4: Code-Review+2
(4 comments)
https://review.coreboot.org/c/coreboot/+/45045/4/src/soc/amd/picasso/memlayo... File src/soc/amd/picasso/memlayout_x86.ld:
https://review.coreboot.org/c/coreboot/+/45045/4/src/soc/amd/picasso/memlayo... PS4, Line 42: PSP_SHAREDMEM_SIZE VB2_FIRMWARE_WORKBUF_RECOMMENDED_SIZE
https://review.coreboot.org/c/coreboot/+/45045/4/src/soc/amd/picasso/memlayo... PS4, Line 44: PSP_SHAREDMEM_SIZE VB2_FIRMWARE_WORKBUF_RECOMMENDED_SIZE
https://review.coreboot.org/c/coreboot/+/45045/4/src/soc/amd/picasso/memlayo... PS4, Line 47: PSP_SHAREDMEM_SIZE VB2_FIRMWARE_WORKBUF_RECOMMENDED_SIZE
https://review.coreboot.org/c/coreboot/+/45045/4/src/soc/amd/picasso/memlayo... PS4, Line 49: PSP_SHAREDMEM_SIZE This should be VB2_FIRMWARE_WORKBUF_RECOMMENDED_SIZE