Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36650 )
Change subject: soc/intel/skylake: Improve comment for DISB
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36650/1/src/soc/intel/skylake/pmc.c
File src/soc/intel/skylake/pmc.c:
https://review.coreboot.org/c/coreboot/+/36650/1/src/soc/intel/skylake/pmc.c...
PS1, Line 39: this bit must be CLEARED
I've added printk()s before/after the write below: […]
Looks like FSP uses this bit for for its own consumption. It seems to be a scratchpad, so we don't have any need to change it in coreboot (unless we want to change things before FSP runs, which seems unlikely)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36650
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ca748ddb245cae632e423a417c6a25d52a15354
Gerrit-Change-Number: 36650
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Nov 2019 16:07:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment