Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34752 )
Change subject: arch/x86: Attempt to boot without postcar stage/phase
......................................................................
Patch Set 5:
Patch Set 5:
As for this change specifically, I haven't looked into the details just yet. A first glance does indicate it's a little messy and could be cleaned up, but it's very much possible to remove postcar and put the CAR teardown at the first part of ramstage. Now whether that's worth it (commit description is 4ms) in comparison to the support cost is another matter that needs to be weighed.
When postcar support was added, there was a similar question about being able to run ramstage directly from romstage and have ramstage do the tear down which postcar currently does. IIUC, the reason for not doing that was to avoid coherency issues. Is that not a concern anymore? Reference: https://review.coreboot.org/c/coreboot/+/14140/3//COMMIT_MSG#14
is that specific to APL? i don't see any such caching related issue so far even on celeron. Might like to hear from Aaron on this ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34752
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc88e6727b2fa692585dffe576e69f6d4d0b349d
Gerrit-Change-Number: 34752
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Thu, 08 Aug 2019 16:17:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment