[coreboot-gerrit] Change in coreboot[master]: mb/google/hatch: Create palkia variant

[Ken Lu (Code Review)]

Ken Lu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38860 )

Change subject: mb/google/hatch: Create palkia variant
......................................................................

Patch Set 10:

(3 comments)

https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/palkia/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... 
PS2, Line 30: GSPI1
> Ack

GSPI1 had removed . Do you jump to 
https://review.coreboot.org/c/coreboot/+/38860/2 
instead of 
https://review.coreboot.org/c/coreboot/+/38860 
?

https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... 
PS2, Line 53: .i2c[3] = {
            : 			.speed = I2C_SPEED_FAST,
            : 			.rise_time_ns = 150,
            : 			.fall_time_ns = 150,
            : 		},
> On CB:33384 (same change as your link), Furquan said: […]

In my memory , the i2c[4] setting will not workable if i2c[3] setting removed . I need to double confirm the setting again .

https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/palkia/ramstage.c:

https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... 
PS2, Line 27: Kohaku
> Ack

Palkia did not use GPP_C11 and GPP_A12 . We had removed this file .