[coreboot-gerrit] Change in coreboot[master]: soc/intel/xeon_sp/cpx: Move soc_final to finalize.c

[Marc Jones (Code Review)]

Attention is currently required from: Martin Roth, Jonathan Zhang, Rocky Phagura, Arthur Heymans, Patrick Rudolph.
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49913 )

Change subject: soc/intel/xeon_sp/cpx: Move soc_final to finalize.c
......................................................................

Patch Set 1:

(3 comments)

File src/soc/intel/xeon_sp/cpx/finalize.c:

https://review.coreboot.org/c/coreboot/+/49913/comment/3127348e_9f43f924 
PS1, Line 21: 	pci_or_config32(pcidev_path_on_root(PCI_DEVFN(0, 0)), 0x80, 1 << 0);
> I know this code is simply being moved. But now is a good time to clean it up also. […]

Agreed, I'm inclined to do that in a follow on.

https://review.coreboot.org/c/coreboot/+/49913/comment/a1561126_9a2faa0c 
PS1, Line 39: BOOT_STATE_INIT_ENTRY(BS_OS_RESUME, BS_ON_ENTRY, soc_finalize, NULL);
> I suppose BS_OS_RESUME is more for laptop. […]

Done

https://review.coreboot.org/c/coreboot/+/49913/comment/28ee9ddd_e126eab8 
PS1, Line 41:
> We should do this on BS_ON_ENTRY, which means just before the PAYLOAD is loaded into memory.

Done